search

flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android
MIT License
594 stars 40 forks source link

if view.superview != nil { view.removeFromSuperview() } #314

Closed chenyunguiMilook closed 3 years ago

chenyunguiMilook commented 3 years ago

https://github.com/flowkey/UIKit-cross-platform/blob/0e44ce485bf0e85fc161e1427970760dc2ff951e/Sources/UIView.swift#L211 should be if view.superview != nil { view.removeFromSuperview() } ?

ephemer commented 3 years ago

Thanks that looks correct. Could you make a pull request for this and add a test?

chenyunguiMilook commented 3 years ago

No problem!

ephemer commented 3 years ago

Thanks, @chenyunguiMilook!

michaelknoch commented 3 years ago

closing this because https://github.com/flowkey/UIKit-cross-platform/commit/196ab113ab457a2c393689317b9fe6c067c75fd7 was merged. Thanks @chenyunguiMilook