flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android
MIT License
594 stars 40 forks source link

clamp subview index _after_ removing from superview #323

Closed rikner closed 3 years ago

rikner commented 3 years ago

Type of change:

Motivation (current vs expected behavior)

314 revealed another bug, where the subview index was not correctly bound-checked and could therefore cause a crash.

Please check if the PR fulfills these requirements

codecov[bot] commented 3 years ago

Codecov Report

Merging #323 (7cd12fa) into master (44f70d6) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   51.15%   51.15%           
=======================================
  Files          87       87           
  Lines        2895     2895           
=======================================
  Hits         1481     1481           
  Misses       1414     1414           
Impacted Files Coverage Δ
Sources/UIView.swift 90.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44f70d6...7cd12fa. Read the comment docs.