make sure Timer does not crash for huge startingTimeInMilliseconds values on 32 bit arch - Githubissues

flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android

MIT License

598 stars 40 forks source link

make sure Timer does not crash for huge startingTimeInMilliseconds values on 32 bit arch #362

Closed michaelknoch closed 2 years ago

michaelknoch commented 2 years ago

Type of change: bugfix

Motivation (current vs expected behavior)

fixes this crash
reverts the first attempt to fix the crash https://github.com/flowkey/UIKit-cross-platform/commit/6cb855df84e9b98638321cdfe87b547b04fc4e91
improves timer to ensure it does not crash for huge startingTimeInMilliseconds values on 32 bit arch

Please check if the PR fulfills these requirements

[ ] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
[ ] There are no dependencies on other PRs or I have linked dependencies through Zenhub
[ ] The commit messages are clean and understandable
[ ] Tests for the changes have been added (for bug fixes / features)