search

flowkey / react-native-home-indicator

A <PrefersHomeIndicatorAutoHidden /> component for react-native
MIT License
80 stars 24 forks source link

allow multiple component instances, improve api, add tests #7

Closed michaelknoch closed 6 years ago

michaelknoch commented 6 years ago

This pr introduces a new component <HomeIndicator autoHidden={true | false} /> which adds the possibility to disable autoHidden in a deeper component level even if another instance of HomeIndicator/PrefersHomeIndicatorAutoHidden is already mounted in tree

This approach is similar to #6 but way more leaner, what do you think @jacobp100 @nerdmed ?

jacobp100 commented 6 years ago

Does it handle the case where you don't specify the autoHidden prop? (<HomeIndicator />)

michaelknoch commented 6 years ago

yeah, it will show a proptype warning and the indicator will not be not hidden. It would be awesome if you could test if its behaving as you would expect ;) @jacobp100

screen shot 2018-05-29 at 19 24 29
jacobp100 commented 6 years ago

This is getting awesome! 🎉

michaelknoch commented 6 years ago

yeah hope so @jacobp100 have you already tested this version? Does it work as expected? Do you have any feedback regarding the code change?

otherwise i will merge and release this soon 🎈

jacobp100 commented 6 years ago

Awesome that this is merged! 😄