search

flownative / flow-aws-s3

Amazon S3 adaptor for Neos and Flow
MIT License
18 stars 33 forks source link

BUGFIX: Fix fetching more than 1000 existing resources on publish #13

Closed liwo closed 6 years ago

liwo commented 7 years ago

When publishing a collection the existing resources in the target bucket are fetched for later clean up. AWS SDK returns up to 1000 objects in one request and offers pagination to fetch more. Using pagination parameter with lowercase spelling causes S3 to always return the first page, providing a marker for the next page, causing an endless loop. This fixes the parameter.

dimaip commented 6 years ago

Why this is not merged? Looks good and quite critical to me.

kdambekalns commented 6 years ago

Why this is not merged?

I couldn't test it easily and wanted a second review by @robertlemke…

dimaip commented 6 years ago

Actually looking at their API it should be lower case marker in request and uppper case in response: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketGET.html

kdambekalns commented 6 years ago

Hah, that would mean the code is correct or their docs are wrong.

kdambekalns commented 6 years ago

Since this targets an older version, I'll merge it anyway. Thanks for verifying the fix!