search

flownative / flow-aws-s3

Amazon S3 adaptor for Neos and Flow
MIT License
18 stars 33 forks source link

BUGFIX: Don't re-publish already existing resources #19

Closed dimaip closed 6 years ago

dimaip commented 6 years ago

Uses the v2 ListObjects API: https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-s3-2006-03-01.html#listobjectsv2

dimaip commented 6 years ago

Would be nice to optimize object traversal in this style: https://github.com/neos/flow-development-collection/commit/879fba19f93d0a8628682698e57da9f1b58ad7d4 But could be done in a different PR.

dimaip commented 6 years ago

@kdambekalns I've fixed your comments, also fixed an upmerge error

kdambekalns commented 6 years ago

Thanks for fixing. I merged in GitHub, had to do it twice, only to get a second empty commit. Sigh. Local clone and a proper IDE FTW. :)

dimaip commented 6 years ago

My bad, did this PR in the middle of a lot of stuff and just copied by hand to Github... Will try to deliver more quality next time ;)