publishFile tries to set public-read

flownative / flow-aws-s3

Amazon S3 adaptor for Neos and Flow

MIT License

18 stars 33 forks source link

publishFile tries to set public-read #30

Closed Lemmork closed 3 years ago

Lemmork commented 4 years ago

I have a private S3-Bucket connected to cloudfront. Adding files in the backend fails, because of the public-read argument which is set in S3Target:publishFile. ($this->s3Client->upload($this->bucketName, $objectName, $sourceStream, 'public-read', $options);)

I think this is only needed, if you want to use your public s3 path. When using cloudfront it would be nice if this argument is configurable and could be set to 'private'.

Tested with release 2.0.4 and Neos 4.3.7

baschny commented 3 years ago

I just stumbled over this fork which contains this enhancement: https://github.com/mkuiphuis/flow-aws-s3/commit/dfcc041e26d774c64331fccd9c506cbc279cdb0d

kdambekalns commented 3 years ago

Fixed with #32