search

flownative / flow-aws-s3

Amazon S3 adaptor for Neos and Flow
MIT License
18 stars 33 forks source link

BUGFIX: Temporary filename might not be unique #45

Closed kdambekalns closed 3 years ago

kdambekalns commented 3 years ago

When uploading a file, uniqid() was used to generate a temporary filename. Uploading a lot of files at the same time could lead to collisions.

This change switches to Algorithms::generateRandomToken() instead.

Fixes #31

kdambekalns commented 3 years ago

We should also check if there's similar code in the flownative/google-cloudstorage code.

There more_entropy is used, but I cleaned it up a bit: https://github.com/flownative/flow-google-cloudstorage/pull/27