search

flownative / localbeach

The Local Beach client written in Go
Apache License 2.0
7 stars 3 forks source link

Reverse loading order of environment files #80

Closed kdambekalns closed 1 month ago

kdambekalns commented 4 months ago

Due to the order of files in https://github.com/flownative/localbeach/blob/27c19379f799449b3ac3038954a961849d743b2b/pkg/beachsandbox/helpers.go#L56 one cannot override a variable from localbeach.dist.env in one of the other files.

Or I am too stupid to see my error…

Should we revert the order, or was this a very conscious choice?

robertlemke commented 3 months ago

It was a conscious choice back then but it probably does not make any sense.

kdambekalns commented 3 months ago

I can prepare a PR to revert the order, if you like.