search

flowplayer / flash-build

contains build files for compiling Flowplayer Flash
10 stars 11 forks source link

Replace/Remove SVN keywords from API script. #7

Open phloxic opened 11 years ago

phloxic commented 11 years ago

Distributing the script with the following in the license header:

 * Date: ${date}
 * Revision: ${revision}

[sic] just looks clumsy.

@anssip - do you have something in place to expand these via Makefile:

 * Date: @DATE
 * Revision: @REVISION

Or should they just be removed?

phloxic commented 11 years ago

Both the license headers of

must be fixed.

phloxic commented 11 years ago

Copyright years must be updated.

anssip commented 10 years ago

flowplayer-src.js is fixed and pushed to releases.flowplayer.org (copyright year also)

phloxic commented 10 years ago

No. flashembed.js + flowplayer-src.js must be concatenated into flowplayer-<version>.js

phloxic commented 10 years ago

It's probably a matter of omitting the removal of flowplayer.js before uglification.

phloxic commented 10 years ago

flashembed.js still has the svn keywords and other unexpanded vars: https://github.com/flowplayer/flash/blob/master/core/src/javascript/flashembed.js These would go into the unminified flowplayer.js if it was built. In theory they also should persist in the minified version as flashembed.js could also be used standalone - if jquerytools was still actively maintained ...

phloxic commented 10 years ago

Proposal:

/**
 * Flashembed - New wave Flash embedding
 *
 * NO COPYRIGHTS OR LICENSES. DO WHAT YOU LIKE.
 */

for the non-minified version - removed automatically in the minified version.

phloxic commented 10 years ago

@anssip - the copyright year is still 2008-2011 in flowplayer-src.js

phloxic commented 10 years ago

@anssip - now all version information is removed from the scripts. It would be better if the build scripted added the release version and release date - as it is done for the fp html5 api.