flowplayer / flash

Flowplayer Flash, the video player for the Web
http://flowplayer.org
282 stars 183 forks source link

rtmp + hw accel + instream clips lose video, or aspect ratio #44

Closed phloxic closed 11 years ago

phloxic commented 12 years ago

http://flowplayer.blacktrash.org/test/instream-accel.html

No video for the instream clip. After invisible instream clip, parent clip is (sometimes) distorted and has the aspect ratio of the instream clip.

Another variant: http://flash.flowplayer.org/forum/7/104184#post-104217

The flowplayer branding is constantly visible.

I still get the bleached colors, but have given up on that.

danrossi commented 12 years ago

Its accessible. The vast feed is simply not configuring ads for me.

ViliusS commented 12 years ago

Is the main VAST feed accessible at http://lt.adocean.pl/ad.xml?id=YVNcq97FnZQVOFPpB.AQSRlYEOMA90LfRRiDYcUChx..c7

Can you download that file and see if there are clips present in XML?

danrossi commented 12 years ago

It is this seems server related its failing to load the crossdomain policy file therefore no feed is loading

http://lt.adocean.pl/crossdomain.xml , i get a faillure and pending http status on chrome.

ViliusS commented 12 years ago

Dan, Paul said that he emailed you with details about the problem.

danrossi commented 12 years ago

I got the ads working, im seeking back and there is no issues with stage video placement at all i tried a few times.

ViliusS commented 12 years ago

Are you sure your browser/Flash/GPU supports hardware acceleration?

danrossi commented 12 years ago

alright sorry about the delay, thankfully it's nothing too deep. You can see when you do a seek heaps forward and ova completely cuts off all events, so the player doesn't receive any seek event which is where I re-enable stage video change events so all this can work properly. Ova is the culprit so ill have to create a work around.

danrossi commented 12 years ago

or get him to fix it.

danrossi commented 12 years ago

please try this with the event listeners disabled https://dl.dropbox.com/u/3394987/flowplayer.commercial-3.2.15.zip

danrossi commented 12 years ago

Going to have to say I have absolutely no idea what is going on, its clearly changing the video display but isn't. This is going to take hours to find the issue with ova.

danrossi commented 12 years ago

doing these debug steps, including this bizarre seek back takes ages obviously each time.

danrossi commented 12 years ago

One thing im noticing is that the ads are not configured for stage video and I think thats what the issue is.

danrossi commented 12 years ago

Lets try working with that first I think.

danrossi commented 12 years ago

I have asked paul to configure accelerated on the ads clip config and hopefully this problem goes away.

ViliusS commented 12 years ago

Tried your latest ZIP with event listeners disabled. Still the same problem. Will have to wait on what Paul thinks about this.

danrossi commented 12 years ago

Yes once the ad is also being configured for acceleration it will hide it correctly.

phloxic commented 12 years ago

That raises the question whether whether combinations of accelerated true and false work inside a playlist? The fact that accelerated is a clip property suggests it should.

danrossi commented 12 years ago

Doesn't look like it, though logically it should be on / off really and thats been the case with most the test casues configured on the common clip, or else it's going to make code very complicated. It will need extra code to remove the video object because it's a different system from the looks of it. So first he should be changing the code to use whatever is set on the common clip object first.

ViliusS commented 12 years ago

I agree. I think there is a ticket for OVA regarding inheritance of main clip properties for ads. Maybe this is related: http://developer.longtailvideo.com/ova/ticket/472

danrossi commented 11 years ago

Hi I finally found the time to dig into the ova code as its pretty huge undertaking to find it. The acceleration code was indeed commented out so not being added Ive notified paul and gave him a fix. Im hoping this fixes everything.

ViliusS commented 11 years ago

That is great news. Thank you Dan! We still need a released Flowplayer version so we can put it into production though.

danrossi commented 11 years ago

I can't do anything about that im afraid but we probably need to wait to find out it all works fine with ova once they change it on their end. the best I can do is compile the fixes.

ViliusS commented 11 years ago

Can you tell me who I must ping for the release? :) Is it Christian or somebody else?

danrossi commented 11 years ago

There is a pull request with a tonne of fixes, once they are in a release might go out.

ViliusS commented 11 years ago

Yes I understand that. But who is responsible to make that happen?

danrossi commented 11 years ago

https://github.com/flowplayer/flash/pull/33 please comment here if possible, anssi checks these in.

danrossi commented 11 years ago

paul is looking at it now !

ViliusS commented 11 years ago

All issues mentioned in this ticket except for one mid roll case which I've mentioned in https://github.com/flowplayer/flash/issues/44#issuecomment-10146738 at least for me are fixed in 3.2.16.

danrossi commented 11 years ago

closing for now