flowplayer / flowplayer-viewport-autoplay

Plugin to start playback when visible in viewport
MIT License
0 stars 2 forks source link

Disable plugin for splash setups? #4

Closed phloxic closed 7 years ago

phloxic commented 7 years ago

I have done that, but there is code which calls api.load() if api.splash state.

So what is/was the intention: Launch splash setups? This will then apply to all players on the page which may not be intended.

@tipiirai - your input, please.

phloxic commented 7 years ago

In theory one could take this as a condition: BOTH autoplay and splash are explicitly set. However, this does not work in practice because on boot (plugin init) api.conf.autoplay is true for splash setups (it should probably only be true for api.video.autoplay, but nevermind).

How about a plugin specific option to enable the plugin in the first place (which then can be set globally or for specifc players), let's say a boolean viewportAutoplay.

If viewportAutoplay is set, the player will try autoplaying regardless of setup, and if it can autoplay.

phloxic commented 7 years ago

To enable this for splash - as it was before - we would have to exclude mobiles. You cannot load a player from splash state on mobiles without user interaction.

I am closing this. @tipiirai - feel free to re-open, if you want to allow this for splash players loaded by users; personally would find this confusing, YMMV.