flowplayer / react-flowplayer

Flowplayer React Component
MIT License
2 stars 4 forks source link

no accurate types or interface exposed to consuming application #49

Open rj-wowza opened 3 months ago

rj-wowza commented 3 months ago

the consuming application is passing a data structure like this into the <Flowplayer> src prop to support "live stream" asset types.

type Source = {
  type: string;
  streamName: string;
  subscriberToken?: string;
  dev?: boolean;
};

But this type is not described or exported from the player package.

This type should be exported from the player package if it is a required data structure, to ensure a proper contract between the package and the consuming app and prevent a mismatch between the consuming app and the player package.

ondreian commented 2 months ago

Yes, this is exactly the current epic we are working on. Reconciling the types exposed with our public npm module, because of the amount of expressiveness typescript affords us now relative to the 5 years ago when I first added the types