flowplayer / wordpress-flowplayer

A plugin for wordpress to show videos with Flowplayer5
http://wordpress.org/plugins/flowplayer5/
GNU General Public License v2.0
13 stars 19 forks source link

fix hlsjs loading #115

Closed bbbo closed 7 years ago

bbbo commented 8 years ago

Despite marking "load HLS plugin" in the settings, it is not loaded so the player falls back to using FlashHLS (flowplayerhls.swf) for HLS streams.

The option should load the hlsjs plugin if marked. it should be set to active by default when creating video posts from Drive, but not for external HLS streams since we cannot be sure whether they have the required CORS headers set.

By default, the plugin should be loaded from our CDN, ie <script src="//releases.flowplayer.org/hlsjs/flowplayer.hlsjs.min.js"></script>

We should have an option in /wp-admin/edit.php?post_type=flowplayer5&page=flowplayer5_settings to set a different path is the user wishes this (use case: new hls.js / hlsjs.js version conflicts with their custom streams)

Perhaps we should creata a "plugin assets" subcategory, where the audio, background and overlay plugins could be defined

edit video wp test wordpress_2016-09-27_13-21-24

sigvenss commented 8 years ago

Hi, thanks for your work with the flowplayer WP plugin! If i understand it correctly the plugin only supports flash when using a HLS feed, not HLSJS? Thanks

sigvenss commented 8 years ago

EDIT: I just edited the frontend/class-flowplayer5-styles-scripts.php file and did what underdude changed, and now it works! Thanks alot guys.

bbbo commented 8 years ago

yup, this was a bug in the last release ;)