flowplayer / wordpress-flowplayer

A plugin for wordpress to show videos with Flowplayer5
http://wordpress.org/plugins/flowplayer5/
GNU General Public License v2.0
13 stars 19 forks source link

add iframe embed option fields #119

Open bbbo opened 8 years ago

bbbo commented 8 years ago

on the configuration page, so users can set an iframe source (and optionally height and width), see https://flowplayer.org/docs/embedding.html#iframe-embedding . The contents will go into the embed: config object, like

embed: { // embed including quality selector iframe: "//flowplayer.org/standalone/multires/drive-iframe.html", width: "864px", height: "364px" // 360 + 4 ! player height + room for slim timeline }

If an iframe is set, also add the fullscreen options to the global configuration? ) @blacktrash any negative side effects?

/ additional global configuration to handle fullscreen behaviour of embedded iframes / flowplayer.conf = {

// allow iframe go fullscreen
fullscreen: true,

// fullscreen from iframe on tablets
native_fullscreen: true

};

phloxic commented 8 years ago

Should not be needed with upcoming flowplayer 7; embed will always be iframe, and iframe will be responsive if neither height or width are given. That includes a better handling of the slim timeline thing as well, because that does not apply to fixed-controls and no-toggle modifier classes (nevermind what will change in the design, may still have to be adapted).

phloxic commented 8 years ago

Also, at least in the current state, the config stuff is meant of the iframe source, which is usually not the player one sees on site?

bbbo commented 8 years ago

the embed option quoted above are for the player setup?

phloxic commented 8 years ago

native_fullscreen and fullscreen are normally only required for the iframe source.

bbbo commented 6 years ago

I think this is still needed as the standard embed iframe does not transport ad configurations for example