search

flowpowered / network

Networking library for the Flow collection.
https://flow.github.io/network
MIT License
26 stars 18 forks source link

Remove frivolous and dangerous calls to .retain() #6

Closed OverCaste closed 10 years ago

OverCaste commented 10 years ago

Solves issues in downstream Glowstone.

Newly created ByteBufs don't need to have .retain() called, only if you're passing a bytebuf unchanged from one handler to another. That isn't the case in any of the calls, and so there are resource leak problems in implementing projects.

Pom version change is just for ease of testing, you can revert at leisure.

kitskub commented 10 years ago

Thanks! Pulled in 6fe1c3c7030064562bbbbee8b2c25074e4909ea5