search

flowup / api-client-generator

Angular REST API client generator from Swagger YAML or JSON file with camel case settigs
MIT License
115 stars 21 forks source link

Add optional filter for unsupported method consume #79

Closed jalmeida-mct closed 5 years ago

jalmeida-mct commented 5 years ago

closes #78

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

João Almeida seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

vmasek commented 5 years ago

Hello, thank you for the PR :+1:

Please revert the package-lock.json and sign the CLA so it can be merged :shipit:

jalmeida-mct commented 5 years ago

Hi, thanks for the quick reply! Sorry for the late response, just pushed the revert. I've also signed the CLA, but maybe I need to fork it from my personal account for it to work?

vmasek commented 5 years ago

@jalmeida-mct there are still changes for both of package-lock.json and you also bumped a version in package.json please revert these changes, I'll do them with release

jalmeida-mct commented 5 years ago

my bad, rebased the whole thing into a single commit

vmasek commented 5 years ago

@jalmeida-mct It tells me that CLA is still not signed, what did you mean by forking it to your personal acc?

It should work in a way that you just click on CLA check in this PR, it redirects you to the CLA bot and then you get redirected back after you agree with terms

jalmeida-mct commented 5 years ago

I mean this is what I see on the CLA page: https://imgur.com/a/v6nfZeq I've definitely hit sign but it doesn't seem to update?