search

flowwer-dev / pull-request-stats

Github action to print relevant stats about Pull Request reviewers
MIT License
366 stars 79 forks source link

Feature: Allow output from action to be consumed in a future step #72

Closed damccorm closed 1 year ago

damccorm commented 1 year ago

For my specific use case, I'm interested in sending an email with the results to a distribution list (the apache/beam developer email list) since we mostly communicate there. While I could add another connector (like the webhook or slack url), email requires a little more config (sender email address and password, recipient email address, email service) which might crowd the options. If we had a generic way of composing this with other actions I could use a send email action or something similar. In general, that kind of composability would be nice :)

manuelmhtr commented 1 year ago

Hi @damccorm It's a great idea. I saw this commit of yours, which I think solves the problem, but then you reverted the change. Don't you think it could work?

Other ideas:

  1. Similar to your commit, I can set 2 outputs: one as a string (with the same content as the Github comment) and the other one as JSON, which can be parsed and manipulated. Would it work?
  2. Another idea for the Beam team might be using Zapier or a similar tool where you can configure a workflow to receive a webhook and then send the results by email or other channels.
  3. I configured the Apache Github account to use all the "Premium Features" for free. The Slack or Teams connectors could be an alternative in the meanwhile.
damccorm commented 1 year ago

Hey, sorry for the slow response, thanks for looking at this!

I saw this commit of yours, which I think solves the problem, but then you reverted the change. Don't you think it could work?

I didn't go with that change because (a) I wasn't sure if it fit the code style here and (b) it was formatted kinda oddly since it was markdown

Similar to your commit, I can set 2 outputs: one as a string (with the same content as the Github comment) and the other one as JSON, which can be parsed and manipulated. Would it work?

I think that would be perfect; the JSON bit in particular would be awesome

I configured the Apache Github account to use all the "Premium Features" for free. The Slack or Teams connectors could be an alternative in the meanwhile.

Thank you, that's awesome!

damccorm commented 1 year ago

The commit itself might be more or less what we need, I just didn't quite get to testing/validating it in full

damccorm commented 1 year ago

Actually, with nodemailer's html option I was able to get this working with just my change; that alone might be enough. I added #76 - let me know what you think!