`thickening_parameter = 1.0` is not possible

flowy-code / flowy

A code to simulate lava flows.

GNU General Public License v3.0

5 stars 1 forks source link

`thickening_parameter = 1.0` is not possible #17

Open MSallermann opened 7 months ago

MSallermann commented 7 months ago

This can currently not be allowed because of the way we compute the final lava flow thickness as

(H_final - H_initial) / (1.0 - thickening_parameter)

In Mr. Lava Loba this works, since they track the thickness differently. For now, I have simply disallowed thickening_parameter=1.0 in the input validation (27b22f8).

MSallermann commented 7 months ago

If thickening_parameter=1.0, the topography does essentially not get modified so there might be some overlap with topo_mod_flag here. See also #13.