Out of scope: `set-gql-registry!`

flowyourmoney / malli-graphql

Generate GraphQL Schemas and Types from malli

MIT License

3 stars 2 forks source link

Out of scope: `set-gql-registry!` #2

Open flow-tiago opened 2 years ago

flow-tiago commented 2 years ago

I don't think this function should exist.

IMO:

the lib should solve the problem of parsing only; registry composition should be up to the user
it wouldn't play well with malli-ts or other parsers

oscar-s-silva commented 2 years ago

Relates to #4. The reason for including a mapping between GraphQL types and helper functions was improving developer and user experience. I now know that the use case is limited to converting graphQL schemas so perhaps you do not wish to maintain unneeded functionality. Other alternatives would include separating helper functions of this nature to a different namespace similar to other libraries.