flox / flox

Developer environments you can take with you
https://flox.dev
GNU General Public License v2.0
2.14k stars 51 forks source link

feat(show): Default --all to true and deprecate #1444

Closed dcarley closed 3 weeks ago

dcarley commented 3 weeks ago

Proposed Changes

feat(show): Default --all to true and deprecate

So that we expose to the user all versions of a pkg_path from the catalog. There's no functional change for the non-catalog code path because pkgdb only ever knows about a single version.

It looks like this defaulted to false because the original design accounted for matching multiple pkg_paths and would later include stabilities:

I've left the flag, hidden it, and added a deprecation warning, in case anyone happens to be using it currently. This can be removed in future releases.

feat(show): Output one version per line

This tidies up the output and will make it easier to copy/paste a specific result. In turn, stop duplicating the pkg_name, which is already printed on the line above with the package description.

Release Notes

ysndr commented 3 weeks ago

Is this PR connected to an issue? Just asking because I wasnt aware we were changing show

dcarley commented 3 weeks ago

Race condition with your comment 😄

image

It came out of this thread: https://flox-dev.slack.com/archives/C06LT2MUPGU/p1715287413853829

ghudgins commented 3 weeks ago

product verified - looks good on a branch! (non-code review)

ysndr commented 3 weeks ago

I think the output is pretty much tested as integration tests now. Noting that we can probably make that a unit test without a lot of effort I'll go queue this anywaysince it does what the ACs called for

mkenigs commented 3 weeks ago

The example output in the man page needs to be updated

dcarley commented 3 weeks ago

The example output in the man page needs to be updated

Darn, I checked that the flag wasn't there, but forgot when it came to the output format. Followed up in https://github.com/flox/flox/pull/1451