search

flox / floxdocs

Curated Flox Documentation
https://flox.dev/docs/
1 stars 0 forks source link

[BUG] Inconsistent spacing between header and sidebar #11

Open zmitchell opened 8 months ago

zmitchell commented 8 months ago

This causes the sidebar to jump around as you click different links in the sidebar.

Screenshot 2024-03-12 at 2 25 28 PM Screenshot 2024-03-12 at 2 25 37 PM

ghudgins commented 7 months ago

I could not reproduce this issue

zmitchell commented 7 months ago

It would be helpful if you listed what you tried

ghudgins commented 7 months ago

there isn't any jumping when you click links at the same heading level. I don't perceive this as a bug

Large GIF (1088x830)

zmitchell commented 7 months ago

"It doesn't jump when you click on these particular links" is a narrow definition for "not a bug". I doubt the original intention of the site is to have the text jump around like this when you click different links in the sidebar.

ghudgins commented 7 months ago

I think it's working as the framework author intended - you're trading sidebar jumping for jumping you to anchor links "down the page" and, if it were me, I would take this implementation over the alternative. If there's a way to do both, great. but this feels like an over optimization of an already good solution (mkdocs is pretty popular and we're basically using vanilla). I suspect the solution we have is good enough and don't think we should work this as a bug