floydhub / floyd-docs

FloydHub's documentation code. Contributions welcome!
https://docs.floydhub.com/
63 stars 67 forks source link

Add dcgan example #64

Closed ReDeiPirati closed 7 years ago

ReDeiPirati commented 7 years ago

Hi FloydHub Team,

This PR is a Sai requests: he has asked me to port the dcgan pytorch on FloydHub and write a simple guide.

Here's some things to do before merge this PR:

I will continue to test the code and fix typos.

houqp commented 7 years ago

Thanks for the awesome guide! I have forked your project into our official github org and granted you write access to the repo. You should be able to develop directly on that repo now :)

EDIT: I deleted the repo from our account since we think it's better to reference the repo from your account directly in the doc so you get full ownership and all the credits :)

ReDeiPirati commented 7 years ago

Thanks for the kind words, really appreciated!! Ok, so I will replace every floydhub/ reference with my account reference on floydhub and we will be ready to merge this PR. Is it ok for you?

houqp commented 7 years ago

Yup, I think that would be better. Just make sure you don't delete the resources from your account ;)

ReDeiPirati commented 7 years ago

Fix typos, improved docs and replaced floydhub reference.

I think we are ready to merge!

houqp commented 7 years ago

The rest looks good to me 👍 , I will wait for @saiprashanths to do the final call.

saiprashanths commented 7 years ago

LGTM! @mckayward This is another good example to add to our docs. Can you please take a look too and ensure it flows with the rest of the docs?

ReDeiPirati commented 7 years ago

Thanks to you all guys!! 👍