search

floydspace / effect-aws

🚰 Effectful AWS
https://floydspace.github.io/effect-aws/
MIT License
49 stars 4 forks source link

Upgrade powertools to V2 #62

Closed mathiasmaerker closed 1 month ago

mathiasmaerker commented 2 months ago

Hey, I just got the message tat powertools v1 is deprecated. Do you have plans (and maybe need support) to implement v2?

floydspace commented 2 months ago

Hey @mathiasmaerker, thank you for raising this issue. I already implemented this as part of this commit, it is available since @effect-aws/powertools-logger@1.3.0 and personally use with powertools v2.7.0

mathiasmaerker commented 1 month ago

Hmm, are you sure? I am on 1.3.0, deleted node_modules and reinstalled via pnpm i and when I check my node_modules I see: image

floydspace commented 1 month ago

hey @mathiasmaerker

it is becasue the @aws-lambda-powertools/logger is peer dependency of @effect-aws/powertools-logger, what you need is include the @aws-lambda-powertools/logger@^2 in your package.json as dependency. Apparently pnpm installs the peer dependency for you if you do not include it, and apparently it installs the closest matching one which is 1.9.0 as stated in dev dependency of the package

I should mention it in readme though, good point

floydspace commented 3 weeks ago

@mathiasmaerker looks like you were right. it supported v2, but till version 2.7.0, now it is fixed