search

floydwch / angular-underscore

Underscore adapter for AngularJS
316 stars 86 forks source link

Make _.delay(), _.throttle(), and _.debounce() karma friendly #21

Open mvindahl opened 9 years ago

mvindahl commented 9 years ago

The three functions share the common trait that they use the native setTimeout function.

In angular, it's best practise to use $timeout instead. It offers the same signature, and on top of that it makes it possible to "short circuit time" from karma tests by calling $timeout.flush().

As far as implementation goes, I'm thinking of something along the lines of making the underscoreModule depend upon $timeout and including the three functions from underscore.js as shivs, replacing all instances of 'setTimeout' with '$timeout'.

If you approve of the idea, I could try to make it work and submit a pull request.

floydwch commented 9 years ago

@mvindahl Good insight! It's nice to see your PR :)

jamiemcconnell commented 9 years ago

+1 :)

AndrewEastwood commented 8 years ago

+1