floydwch / angular-underscore

Underscore adapter for AngularJS
316 stars 86 forks source link

Registering filters 3 times #23

Open Timvissers opened 9 years ago

Timvissers commented 9 years ago

Hello,

You are registring the filters in the underscore, the filters and the specific filter (per name) module. This means a filter with the same name is registered 3 times. Of course you can choose what module you are loading as a dependency of an application.

I just wanted to mention that I think it's not good practice to load a filter with a certain name 3 times. And scripts like stop-angular-overrides are treating this as errors (which is good imho).

Best regards, Tim

bastijns-jeroen commented 9 years ago

+1