search

floydwch / angular-underscore

Underscore adapter for AngularJS
316 stars 86 forks source link

Consider a bower package? #9

Open fraserxu opened 10 years ago

fraserxu commented 10 years ago

I've been using this in my project, but we are using bower as the package manager. Have you consider to make it installable through bower?

BTW, in order to use this, I also have to include underscore in my bower.json file, I want something like angular-underscore in my json file, thanks!

floydwch commented 10 years ago

I've added bower.json without testing, would you mind to test it?

And since considering Lo-Dash, the decision of underscore or Lo-Dash as the infrastructure is remained with users, i.e., you can include 'underscore' or 'lodash', depends on you .

fraserxu commented 10 years ago

If you say so, why not have another one named angular-lodash. The name would be confusing if you let people choose which library to use, no?

floydwch commented 10 years ago

@fraserxu Because Lo-Dash is as a drop-in replacement for underscore, if include underscore directly in this package, one can't have other choice for consideration, so leave it for users might be better.

Also, this package's description is "Underscore adapter for AngularJS", i.e., it's just an adapter, not an implementation of underscore.

sentenza commented 10 years ago

@floydsoft I've tested installing ver. 0.4.0 but I have this error in return:

bower angular-underscore#~0.4.0     ENORESTARGET No tag found that was able to satisfy ~0.4.0
Zmetser commented 10 years ago

Indeed. Tagging the releases would be nice. But in the meantime just do bower angular-underscore it'll check out the master.

bower info angular-underscore

sentenza commented 10 years ago

Yes, I already did that to fix the dependency.

fraserxu commented 10 years ago

@sentenza You can only try install it directly without adding the version.

tomaszkrym commented 10 years ago

+1 for tagging the version - my webapp stopped working because of the fact, that angular-underscore was updated to latest version, while I had older version of underscore in bower.

floydwch commented 10 years ago

@tomaszkrym I added the tag v0.5.0, could you mind to test for it?

tomaszkrym commented 10 years ago

@floydsoft it works fine, thanks!