floydwch / kaggle-cli

(Deprecated, use https://github.com/Kaggle/kaggle-api instead) An unofficial Kaggle command line tool.
MIT License
675 stars 92 forks source link

The condition for while in config.py was changed. #37

Closed niwashing closed 7 years ago

niwashing commented 7 years ago

I found kaggle-cli doesn't work on Windows. Procedure get caught in an endless loop in get_config_candidates() in config.py. This is because the condition curdir != '/' for while loop in get_config_candidates doesn't work on Windows, because '/' doesn't match with Windows' root directory. In Windows os, root directory is not always the same, since there are some drives such as C:, D:. So I suggest that the while loop is broken when curdir is not changed.

floydwch commented 7 years ago

merged, thanks!