search

flozz / rivalcfg

CLI tool and Python library to configure SteelSeries gaming mice
https://flozz.github.io/rivalcfg/
Do What The F*ck You Want To Public License
761 stars 61 forks source link

Unrecognized arguments error when no device is found. #213 #214

Closed LennardKittner closed 1 year ago

LennardKittner commented 1 year ago

Solves #213 by checking if a supported device is found; if not, "E: No supported device found." is printed and the program exits.

I also fixed two typos in cli.py.

LennardKittner commented 1 year ago

Strange on my device, all tests pass.

LennardKittner commented 1 year ago

I fixed the tests by changing the occurrences of sys.argv in main to args. This fixes the tests because sys.argv is empty in tests and args holds the real arguments. However, this change also makes sense if we are not running tests because args is the actual function parameter and sys.argv is just the default value.

flozz commented 1 year ago

Hello,

I will have no time to review this before ~ 1 or 2 weeks. I just want to let you know that I am not ignoring your PR :)

LennardKittner commented 1 year ago

Alright, thank you for letting me know :)

flozz commented 1 year ago

Merged, thank you for the PR (and nice catch for the sys.argv... ^^'). It will be released with next rivalcfg version. :)