flpvn / wittytwitter

Automatically exported from code.google.com/p/wittytwitter
0 stars 0 forks source link

Proxy Authentication password should be encrypted when stored in Settings #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The proxy authentication username/password, at least in my case, 
represents the user's Active Directory username/password.  As such, I'd 
rather not have that stored in plain text within the user.config file.

Original issue reported on code.google.com by jasonf.r...@gmail.com on 7 Jul 2008 at 10:00

GoogleCodeExporter commented 9 years ago
1. Added the encrypt/decrypt functions to Options.xaml.cs and to 
WebProxyHelper.cs 
(almost identical to the same function in TwitterNet.cs, except does not use 
SecureString)
2. Realized that it would be a breaking change for people who have previously 
saved 
proxy credentials, so I prefixed the encrypted string with "WittyEncrypted:" 
when 
saved to the AppSettings.  If the saved text does not start with 
"WittyEncrypted:", 
then it is used verbatim (this is the "legacy" use case), else it is decrypted. 
 The 
password will always be encrypted now when Options are saved.
3. Changed the behavior that requires a restart when the web proxy settings are 
changed (changes now take place without requiring a restart).
4. Improved error handling in regards to Proxy Authentication and Proxy Server 
Not 
Found types of exceptions.

Original comment by jfol...@gmail.com on 17 Jul 2008 at 1:36