search

flpvn / wittytwitter

Automatically exported from code.google.com/p/wittytwitter
0 stars 0 forks source link

@ autocomplete not functioning correctly #190

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Launch latest experimental
2. Type @ in a new tweet

What is the expected output? What do you see instead?
Typing @ results in $1 followed by the twitter name of the first user 
alphabetically. The keyboard shortcuts (tab, up, down) to select the user 
don't work. Typing another letter does not continue the autocomplete.

What version of the product are you using? On what operating system?
Experimental, Vista x64

Original issue reported on code.google.com by johnshee...@gmail.com on 19 Jan 2009 at 7:32

Attachments:

GoogleCodeExporter commented 9 years ago 
The attached screengrab doesn't show that the text immediately following $1 is 
highlighted.

Original comment by johnshee...@gmail.com on 19 Jan 2009 at 7:33

GoogleCodeExporter commented 9 years ago 
If you follow someone who's twitter name starts with a number (like 
@37Signals), it 
breaks the autocomplete. It also crashes witty if you follow a user like this 
and 
type @ somewhere other than the first character in the box

see 
http://www.screencast.com/users/JohnSheehan/folders/Jing/media/3dc81c57-f0da-
4cc6-a4e7-19bbd718ff36

Original comment by johnshee...@gmail.com on 28 Jan 2009 at 6:17

GoogleCodeExporter commented 9 years ago 
This is also occurring for me, except I'm not using the experimental version 
(2.1.0.540). I often get $137signals when trying to @ someone. Will try 
unfollowing 
37signals (and any other numerical ones) to check.

Original comment by ross.mas...@gmail.com on 30 Jan 2009 at 4:58

GoogleCodeExporter commented 9 years ago 
I'm not a regex wizard, so I'm sure there is a more elegant way to fix this.  
Here is
a patch to fix this issue for now.

Original comment by cbrol...@gmail.com on 31 Jan 2009 at 2:32

Attachments:

GoogleCodeExporter commented 9 years ago 
correct me if I'm wrong but won't that patch replace all spaces in the text box 
so if 
I had typed "Hey check out this tweet by @blehbleh" it would change that to 
"Heychecloutthistweetby@blehbleh" ???

Original comment by kris.sc...@gmail.com on 31 Jan 2009 at 5:53

GoogleCodeExporter commented 9 years ago 
I believe by escaping the $1 with ${1} (which inside a string.Format must be 
${{1}}) 
it will solve the problem.  Patch attached.

Original comment by kris.sc...@gmail.com on 31 Jan 2009 at 6:14

Attachments:

GoogleCodeExporter commented 9 years ago 
@kris.scott Yeah, if there is text before the @<name> it would remove the 
spaces,
didn't see that, late night.  I'll fix it, thanks!

Original comment by cbrol...@gmail.com on 31 Jan 2009 at 6:15

GoogleCodeExporter commented 9 years ago 
@kris.scott Just saw your post, cool patch.

Original comment by cbrol...@gmail.com on 31 Jan 2009 at 7:01

GoogleCodeExporter commented 9 years ago 
Applied patch. Thanks for catching and fixing this, guys!

Original comment by jongallo...@gmail.com on 2 Feb 2009 at 8:23