flpvn / wittytwitter

Automatically exported from code.google.com/p/wittytwitter
0 stars 0 forks source link

Clicking on User tab crashes when I click on it after logging in #303

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Log in using the e-mail address I signed up with on my Twitter account.
2. Click on 'User'
3. A crash occurs and I get a message within Witty - "@my@email.com does 
not exist (probably mispelled)

What is the expected output? What do you see instead?
I expect to see tweets made by my user account.  (This feature works fine 
if I log in with my twitter name.)

What version of the product are you using? On what operating system?
2.4 on Windows 7

Please provide any additional information below.
I believe that the problem is that the account (when it is an e-mail 
address) is not being escaped correctly when searching for account 
information.  I'm going to look into this a bit on my own.  Will submit a 
patch if I figure it out.

Original issue reported on code.google.com by jason.ca...@gmail.com on 8 May 2010 at 6:29

GoogleCodeExporter commented 9 years ago
After taking a cursory look at the problem, it appears that if the user logs in 
using 
an e-mail address, it is not converted over to their Twitter name upon login.  
This is 
the real problem and should be fixed (I might be able to do that).  The problem 
occurs 
because Twitter doesn't use e-mail addresses to try to retrieve user tweets, 
etc and, 
as a result, does not find the user.  At the very least, this problem should be 
handled 
more gracefully.

I will take a look at it and see if I can provide a patch.

Original comment by jason.ca...@gmail.com on 8 May 2010 at 6:36

GoogleCodeExporter commented 9 years ago
The problem arises from the LoginControl.xaml.cs which assigned the text in the 
UsernameTextBox to the AppSettings.Username.  The problem is that a Twitter 
user can 
login with either their Twitter screen name OR their e-mail address.  In the 
case 
that the user logs in with their e-mail address, this doesn't work with the 
user tab 
(which you call in MainWindow.xaml.cs at line 1993) due to the way that Twitter 
retrieves information.  I attached a simple patch which fixes this problem by 
assigning the screen name to AppSettings.Username, rather than the login name.

I would recommend further testing of my patch.  I tested the basics (and it 
appears 
to work), but I haven't had a chance to go through some of the fringe cases.

Hope this helps!

Original comment by jason.ca...@gmail.com on 10 May 2010 at 12:37

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jason.ca...@gmail.com on 13 May 2010 at 3:44