search

flpvsk / gatsby-plugin-gtag

Gatsby plugin to add Google Analytics gtag.js (replacement for analytics.js) to a site.
MIT License
28 stars 12 forks source link

Made the changes requested for pull request #19 #20

Open magp3 opened 4 years ago

magp3 commented 4 years ago

Made based on the changes submitted by @atomicpages issue #18

jonny-harte commented 4 years ago

Any idea when this will be merged?

magp3 commented 4 years ago

@jonny-harte I have no idea but in the meantime you could load it yourself, as a local plugin.

https://www.gatsbyjs.com/docs/loading-plugins-from-your-local-plugins-folder/

flpvsk commented 4 years ago

Please address that comment – https://github.com/flpvsk/gatsby-plugin-gtag/pull/19#discussion_r382800319

I'd suggest to remove the whole createFunctionWithTimeout and leave it up to the user to wrap the callback with setTimeout if they need to.

jonny-harte commented 4 years ago

Thanks @magp3 I'll look at that as a temporary solution. Are you not able to address @flpvsk comment?