search

flr / FLBEIA

Bio-Economic Impact Assessment of Management strategies using FLR
11 stars 13 forks source link

manual and tutorial indicators to update #32

Open vtrijoulet opened 4 years ago

vtrijoulet commented 4 years ago

Just some minor comments as some function indicators in the manual are out of date (cf. 09_FLBEIA_Output_Summary.tex): "income" and "profits" do not exist anymore. I assume income was changed by "grossValue" and profits by "grossSurplus"?

The tutorial at https://github.com/flr/doc/blob/master/FLBEIA_A_Simple_Example.Rmd needs updating since it uses "income" and "profits" in the examples.

Cheers,

Vanessa

dorleta commented 4 years ago

Hi Vanessa,

Thank you for noticing the error.

The names were changed in the last revision of the indicators and you are right income corresponds to ‘grossValue’ and profits to ‘grossSurplus’. We are in the process of uploading the updated tutorials with the correct names and other changes, coming soon I hope.

Cheers,

Dorleta

De: Vanessa Trijoulet notifications@github.com Enviado el: miércoles, 12 de febrero de 2020 17:10 Para: flr/FLBEIA FLBEIA@noreply.github.com CC: Subscribed subscribed@noreply.github.com Asunto: [flr/FLBEIA] manual and tutorial indicators to update (#32)

Just some minor comments as some function indicators in the manual are out of date (cf. 09_FLBEIA_Output_Summary.tex): "income" and "profits" do not exist anymore. I assume income was changed by "grossValue" and profits by "grossSurplus"?

The tutorial at https://github.com/flr/doc/blob/master/FLBEIA_A_Simple_Example.Rmdhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflr%2Fdoc%2Fblob%2Fmaster%2FFLBEIA_A_Simple_Example.Rmd&data=02%7C01%7C%7Cd4e10fa8d2ec4e8843f708d7afd6118d%7C6219f1193e794e7facdea5750808cd9b%7C0%7C0%7C637171206255672951&sdata=O%2FAR9WNpTc91C4ojN359CY2DpiilV6UxVmES2ofuDHg%3D&reserved=0 needs updating since it uses "income" and "profits" in the examples.

Cheers,

Vanessa

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflr%2FFLBEIA%2Fissues%2F32%3Femail_source%3Dnotifications%26email_token%3DABGP2MT7GBG6H6RMPFFJQHTRCQNO7A5CNFSM4KT4W6QKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IM7RS2Q&data=02%7C01%7C%7Cd4e10fa8d2ec4e8843f708d7afd6118d%7C6219f1193e794e7facdea5750808cd9b%7C0%7C0%7C637171206255672951&sdata=dd%2FcU%2BBxxDiE0Hpp8ly62jJIOhBQW3T5zH8A1hwvDg4%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGP2MXZSJZP3HBLMIBNM7TRCQNO7ANCNFSM4KT4W6QA&data=02%7C01%7C%7Cd4e10fa8d2ec4e8843f708d7afd6118d%7C6219f1193e794e7facdea5750808cd9b%7C0%7C0%7C637171206255682947&sdata=SamHJyEPYT31%2FLfKgfILbGg20iN%2BhBh7UWb2Jr9daio%3D&reserved=0.