Proposed fixes for issues #111and #112

flr / FLa4a

The repository for the JRC initiative on stock assessment

https://fishreg.jrc.ec.europa.eu/web/a4a

12 stars 6 forks source link

Proposed fixes for issues #111and #112 #112

Closed iagomosqueira closed 7 years ago

iagomosqueira commented 7 years ago

uoms in a4aFit: fix will work only with FLCore >= 2.6.4.9000 (gh 20170829)
fit methods for FLIndex: simply pass on ll arguments to FLIndices method after calling FLIndices(IND=indices)
Check for windows and 64 bit: In .onAttach, stop() with msg. We could suggest contacting a4a team. Needs sessionInfo from utils

Minor tweaks to .Rbuldignore

iagomosqueira commented 7 years ago

.onAttach code failing on windows in appveyor, will check

iagomosqueira commented 7 years ago

devtools::install_github('flr/FLa4a', ref='issues%23111%23112')
devtools::install_github('flr/FLCore')

library(FLa4a)

data(ple4)
data(ple4.index)

#111 Define sca(FLStock, FLIndex) 

fit1 <- sca(ple4, ple4.index)
fit2 <- sca(ple4, FLIndices(IND=ple4.index))

all.equal(fit1, fit2)

#112  units in slots of a4aFit
# Works only witgh FLCore >= 2.6.4.9000

qapply(fit1, units)