fls-bioinformatics-core / auto_process_ngs

Scripts and utilities for automatic processing & management of Illumina NGS sequencing data.
Other
9 stars 6 forks source link

'publish_qc' command doesn't properly verify non-standard QC protocols #979

Closed pjbriggs closed 5 days ago

pjbriggs commented 1 week ago

The publish_qc command doesn't correctly handle non-standard QC protocols: the protocol name is extracted from the qc.info file for the QC directory and passed directly to the report_qc.py utility, but if this is not one of the built-in protocols then the utility immediately stops with exit code 1 (indicating that the QC has not been verified).

A better way to handle this would be to allow report_qc.py to use the QC protocol specification for verification directly from the stored metadata (which is the default), with the protocol name used as a fallback if no specification is stored.

(This bug manifests itself for example when attempting to publish QC reports for projects that have used custom protocols which are not in the list of built-in protocols.)