search

flucoma / flucoma-sc

Fluid Corpus Manipulation plugins for Supercollider
BSD 3-Clause "New" or "Revised" License
70 stars 16 forks source link

Why does FluidUMAP `.kr` ask for numDimensions? #123

Closed tedmoore closed 2 years ago

tedmoore commented 2 years ago

As you can see here:

Screenshot 2022-06-28 at 12 30 52

When I call .kr on FluidUMAP it gives the option of specifying the number of dimensions. This seems strange because that isn't modifiable after a fit so it is, at least, redundant here, probably confusing.

It seems to have no effect, no matter what value I put it in just returns the number of dimensions it was previously fit for (unless you pass an output buffer that is the wrong size, in which case it sort of fails silently, outputting zeros or near-zeros)

Perhaps this is a sort of "copy/paste" error from something like PCA which might allow one to ask for a different number of PCs after a fit?

weefuzzy commented 2 years ago

Indeed, this is wrong and misleading and would have no effect server-side. It should be killed with fire.

Only FluidUMAP#kr would need to change, as far as I can see: have at it.