search

flucoma / flucoma-sc

Fluid Corpus Manipulation plugins for Supercollider
BSD 3-Clause "New" or "Revised" License
70 stars 16 forks source link

FluidBufNMF argument `resynthMode` is redundant #128

Open tedmoore opened 2 years ago

tedmoore commented 2 years ago

FluidBufNMF's argument resynthMode is currently used to specify whether or not the object should perform resynthesis after decomposition and write it into the buffer specified by resynth. Because a buffer needs to be specified by resynth, this is enough to indicate to the object that resynthesis should occur, therefore resynthMode is redundant.

I propose that we remove the resynthMode argument from the class definition in SuperCollider. The class definition can simply check if resynth is a buffer or nil, and if it is a buffer pass "resynthMode = 1" to the client.

I understand that this will break parity with the other CCEs and I still think it makes sense to do. I'm happy to implement if agreement is reached.

tedmoore commented 2 years ago

@tremblap pointed out that this would mean the docs would need a way to render the resynthMode argument for Max and Pd but not in SuperCollider. I'm kind of poking at this now, but thought I would also alert @weefuzzy to this idea just in case I'm going to hit a wall he can already envision.