Open elgiano opened 2 years ago
Good point (and I guess we should assert that the server
for each passed Buffer
actually matches). The scale of breakage will be pretty immense though, so I'd be inclined to think carefully about how / when such a change could be deployed. It might be more of a v2 thing?
I know this is a breaking interface change, but since it's impossible to have a buffer on one server and run the analysis on another, I think the server argument is redundant for all buffer processes. Such processes can get the server instance from the source buffer that gets passed to them:
Since BufProcesses have already lots of args usually, I think that removing a redundant one would contribute to cleaner (e.g. more understandable/actionable) code