fluencelabs / dev-rewards

Apache License 2.0
554 stars 368 forks source link

age report URL still not redacted #112

Open FiloSottile opened 3 months ago

FiloSottile commented 3 months ago

https://github.com/FiloSottile/age/issues/550, https://github.com/FiloSottile/age/issues/551, https://github.com/FiloSottile/age/issues/552, https://github.com/FiloSottile/age/issues/553, https://github.com/FiloSottile/age/issues/556, https://github.com/FiloSottile/age/issues/557, and https://github.com/FiloSottile/age/issues/558 were all filed after #19 was closed, and a couple show transcripts with the age report URL still.

I must insist, this time with some annoyance, that you redact the age report URL from your claim script outputs.

folex commented 3 months ago

Hello! First of all, thank you for all the work on age! 🙏

I'm so sorry it still gets channeled to you. I understand the annoyance it should generate. We will fix it ASAP!

folex commented 3 months ago

This should help https://github.com/fluencelabs/dev-rewards/pull/113

I'll give it a few tests to make sure it never contains link to your report page 🙏 And after review, we'll merge it.

Sorry for the trouble!

folex commented 3 months ago

The only place left that I'm not sure how to address is our small web page, on the screenshot.

We advise users to run age directly, and in case of an error it will obviously print the native Age error, with the report URL in it.

claim through web

I have reviewed the issues you linked, and it seems there were no reports related to this web page approach. I guess that's because it makes it impossible to specify wrong SSH key.

So, I suggest to see if any reports regarding direct Age call will appear. If they will, then I guess we can have a small bash wrapper that would sed the URL out of the age error.

I'm hesitant to do that right away, even 1 bash script is already too much when it comes to accessing private keys :) Users calling age directly sounds so much better.

What do you think?

folex commented 2 months ago

We have merged the PR, hopefully that helps 🙏

I won't close the issue for now, so that we all understand it might be only a partial solution, and can continue the discussion here.

Thank you for reaching out, and sorry again!