fluent-ffmpeg / node-fluent-ffmpeg

A fluent API to FFMPEG (http://www.ffmpeg.org)
MIT License
7.63k stars 873 forks source link

V3 experiments #1235

Open njoyard opened 7 months ago

njoyard commented 7 months ago

Complete API rewrite.

New dev tooling

New API principles

await ffmpeg({
  input: 'path/to/input.webm',
  output: {
    target: 'path/to/output.mp4',
    video: { codec: 'h264', bitrate: '1M' },
    audio: false
  }
}).run()

Dropped features

The following features were not reimplemented:

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 6889204749


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/capabilities.ts 53 71 74.65%
src/process.ts 152 175 86.86%
src/command.ts 64 94 68.09%
src/main.ts 0 32 0.0%
src/utils/parsing.ts 231 316 73.1%
<!-- Total: 1040 1228 84.69% -->
Totals Coverage Status
Change from base Build 6856211874: -6.1%
Covered Lines: 1040
Relevant Lines: 1228

💛 - Coveralls
cmd430 commented 7 months ago

I'm still debating whether to include a compatibility layer that emits deprecation warnings

my $0.02 since v3 is a major version bump breaking changes should be expected, adding a compatibility layer just adds unnecessary complexity

gabrielstuff commented 4 months ago

Do you need help on this ? @njoyard

njoyard commented 1 month ago

@gabrielstuff not really, it's taking a bit of time due to real life :)

But if you want to submit PRs on this branch, feel free.