fluent-ffmpeg / node-fluent-ffmpeg

A fluent API to FFMPEG (http://www.ffmpeg.org)
MIT License
7.85k stars 874 forks source link

2? #1255

Closed s1nistr4 closed 1 day ago

princefishthrower commented 6 months ago

Yep, and there is an ugly issue when trying to package anything ES that uses this library (at least when packaging with Rollup, but I guess the root problem lies within this package)

[!] (plugin rpt2) RollupError: [plugin rpt2] ./lib-cov/fluent-ffmpeg?commonjs-external: Could not resolve "./lib-cov/fluent-ffmpeg" from "./lib-cov/fluent-ffmpeg?commonjs-external"

Going to snoop around the other 300+ (!) open issues here to see if there is a solution....

Gahaghan commented 4 months ago

I'm glad to see this project waking up, but I have a minor warning.

The update from from version 2.1.2 to 2.1.3 has a small breaking change. Version 2.1.2 works with Node 16. Version 2.13 requires Node 18+. I understand that Node 16 has reached end of life, but after 7 years perhaps there should have been a version bump to 2.2.0.

I had to change my package.json dependencies setting from

"dependencies": { "fluent-ffmpeg": "^2.1.2" }

TO

"dependencies": { "fluent-ffmpeg": "2.1.2" }