search

fluent-ffmpeg / node-fluent-ffmpeg

A fluent API to FFMPEG (http://www.ffmpeg.org)
MIT License
7.62k stars 872 forks source link

Fix ffmpeg 7 compatibility #1265

Closed MarianoFacundoArch closed 1 month ago

Azarattum commented 2 months ago

Would it break with the older versions after this PR or would it support both?

MarianoFacundoArch commented 2 months ago

My code works on both

totallytavi commented 1 month ago

Made a patch for this. You can download and use it by placing it in a folder called "patches" in your project and running npx patch-package fluent-ffmpeg+2.1.2.patch

njoyard commented 1 month ago

@MarianoFacundoArch can you please revert style changes in lib/capabilities.js? I'll merge it after that.

govindrai commented 1 month ago

@MarianoFacundoArch could you revert the style changes please? It makes the PR very difficult to review and folks could use this update.

Fwiw, I tried downloading your package fluent-ffmpeg-7 and ran into the same issues.

totallytavi commented 1 month ago

@govindrai If you want a fix now, try the patch file I attached above.

totallytavi commented 1 month ago

@njoyard Opened #1274 which achieves the same, just no style formats

njoyard commented 1 month ago

Replaced by #1274