search

fluent-plugins-nursery / fluent-plugin-systemd

This is a fluentd input plugin. It reads logs from the systemd journal.
Apache License 2.0
153 stars 43 forks source link

Gracefully handle corrupted journal log entries #49

Closed chancez closed 7 years ago

chancez commented 7 years ago

This is a back port of https://github.com/reevoo/fluent-plugin-systemd/pull/41 to the 0.0.x branch. If you don't want to accept this; I understand, but I saw some others who requested this so I figured I would open a PR.

reevoo-samuel commented 7 years ago

Er, hello?

This Pull Request is too damn old! Merge or close this, sucka.

chancez commented 7 years ago

Sorry, hadn't had a chance to look into the issue too much; I hadn't seen it before. I believe it's a ruby version thing and travis is using the latest version of ruby at least on the 0.8 based branches.

We'll see if my latest commit fixes that.

chancez commented 7 years ago

Tests pass; rubocop fails but its for unrelated things since nothing has changed relating to it's complaints. I'm guessing it's a newer rubocop or something that fails with the older 0.8 branch. I don't really know much about rubocop so I'm not 100% sure what the solution to that is besides just fixing these things?

errm commented 7 years ago

Looks good to me... thanks for the PR

chancez commented 7 years ago

i got everything to pass :)