Also Run tests on Centos - Githubissues

fluent-plugins-nursery / fluent-plugin-systemd

This is a fluentd input plugin. It reads logs from the systemd journal.

Apache License 2.0

153 stars 43 forks source link

Also Run tests on Centos #5

Closed errm closed 8 years ago

reevoo-samuel commented 8 years ago

_If you're new, read the guidelines._

Good code is tested, designed for change, easy to understand and able to cope when things go wrong.

Good pull requests are descriptive, small and short-lived.

For the Author

[x] Description explains what you have done and why.
[x] Tests have been written (or you have explained why you don't need tests).
[x] Documentation/comments have been added/updated.

For the Reviewer

[ ] The code is well-designed and able to cope with change.
[ ] The code is easy to understand.
[ ] Tests cover happy and unhappy paths in the code.
[ ] Tests are green on CI (or pulled/tested on your machine).

reevoo-samuel commented 8 years ago

I don't see any comments on your Pull Request.

Are you too good for code reviews now? No. No you aren't.

Maybe you forgot to say who reviewed it. That's fine, but let me know.