search

fluent-plugins-nursery / fluent-plugin-systemd

This is a fluentd input plugin. It reads logs from the systemd journal.
Apache License 2.0
153 stars 43 forks source link

storage_create needs either type or conf #75

Closed damluji closed 5 years ago

damluji commented 5 years ago

in both fluent 1.3.3 and 1.4.0 the function storage_create sets both type and conf to be nil by default, and expects ONE of them at least to be set or it will throw an ArgumentError, "BUG: both type and conf are not specified"

/lib/fluent/plugin_helper/storage.rb line 32: def storage_create(usage: '', type: nil, conf: nil, default_type: nil)

errm commented 5 years ago

This doesn't look right ... we should be getting these from the config ...

reevoo-samuel commented 5 years ago

Er, hello?

This Pull Request is too damn old! Merge or close this, sucka.

nabeken commented 5 years ago

I ran into the same issue. It was very hard to figure out what was going on... then I decided to write down like the following:

  <storage>
    @type local
    persistent true
    path /var/log/td-agent/systemd.pos
  </storage>
reevoo-samuel commented 5 years ago

Er, hello?

This Pull Request is too damn old! Merge or close this, sucka.

reevoo-samuel commented 5 years ago

Er, hello?

This Pull Request is too damn old! Merge or close this, sucka.