fluent-plugins-nursery / fluent-plugin-windows-exporter

Fluentd plugin to collect Windows metrics
Apache License 2.0
3 stars 2 forks source link

Add support for Ruby 3.1 #16

Closed fujimotos closed 2 years ago

fujimotos commented 2 years ago

Introduction

We are plannning to bundle fluent-plugin-windows-exporter in TD Agent, starting from the next version (the release date will be March 2022).

Since TD Agent is now moving to Ruby 3.x, we also need to confirm that this plugin works on Ruby 3.1 as well.

Task

Strategic priority

See https://github.com/fluent/fluentd/pull/3585 for migration status.

daipom commented 2 years ago

@fujimotos Thank you for the clear assignment.

https://github.com/fluent-plugins-nursery/fluent-plugin-windows-exporter/actions/runs/1845181374

I have added Ruby 3.1 in the add-ci-support-ruby31 branch and all tests have passed in Ruby 3.1.

Would merging this into master complete this task?

fujimotos commented 2 years ago

@daipom Thank you! Marged via 6e3833d80a6d7df7c07e3303a22481f00212a509.

daipom commented 2 years ago

Thank you for merging!

fujimotos commented 2 years ago

Addendum: I documented the supported Ruby version in 8c9ad68d5def9d3715086ea4e1a53e9cefc0a433.

daipom commented 2 years ago

Nice! Thank you!