Upgraded to VS2017 and added NetStandard 2.0

[snakefoot]

Also made some minor changes:

• No longer catches all exceptions, but gives them to NLog (NLog uses the exception to notify wrappers about failures)
• Added more logging about failures, so they can be monitored in NLog-InternalLogger.
• Fixed the nuget-package so it correctly uses MsgPack.Cli ver. 0.8.0 (Instead of ver. 0.4.1)
• Removed allocation of SerializationContext for every message property
• Added support for possible null values in dictionary (Prepare for IncludeAllProperties)
• Ensure Cleanup never fails.
• Ensure Cleanup followed by a failed EnsureConnected doesn't lead to a broken emitter.

[repeatedly]

@moriyoshi Do you have a time for this patch?

[moriyoshi]

I'm taking a look into this.

[snakefoot]

@moriyoshi Have implemented the suggested changes.

[moriyoshi]

I'd like to keep this compatible with the older versions of NLog whose current minimum requirement of .NET version is 3.5, while .NET Standard 2.0 apparently requires 4.5 or above. Do you have any idea on this? Not every user can lift up their NLog requirements.

[snakefoot]

Your current project only supports net45, so not sure why you mention net35.

I have configured the new Nlog.Targets.Fluentd.csproj, so Net45 uses Nlog 2.1.0, and NetStandard20 uses Nlog4.5

One just have to dotnet pack and will generate a nice nuget package

[moriyoshi]

Your current project only supports net45, so not sure why you mention net35.

Yep, but there wasn't much intention. I'd thought the code base could be compiled with .NET 3.5 without much work at the time I published this project.

I have configured the new Nlog.Targets.Fluentd.csproj, so Net45 uses Nlog 2.1.0, and NetStandard20 uses Nlog4.5

That sounds OK. The problem I was seeing is that older NLog (<4.5) don't have structural logging capability, nor the accompanying API so it appears the new code base cannot be compiled with the older versions.

[snakefoot]

The structural logging is just using LogEventInfo.Properties that also exist in Nlog ver. 2.1. The Nlog.Targets.Fluentd still supports Nlog 2.1 for net45. It is only Netstandard that needs the new Nlog 4.5

I can create a new PR that adds support for net35 and net40. When this has been merged

[snakefoot]

@moriyoshi Have added net35 and net40 as build targets, so the nuget-package will also support those platforms (Also with NLog 2.1 as minimum version).

Because you want the now obsolete net35, then you cannot use dotnet pack. Instead you have to do it like this (From a developer command-prompt):

msbuild /t:Restore,Pack .\src\NLog.Targets.Fluentd /p:Configuration=Release /p:IncludeSymbols=true /verbosity:minimal

Or just right-click the project in Visual Studio 2017 and choose "Pack".

[snakefoot]

@moriyoshi Something that I'm missing, before this can be merged?

[moriyoshi]

Looks great! Apologies for leaving this for a long time. I think I can merge this then.