fluent / fluent-bit-docker-image

Docker image for Fluent Bit
https://hub.docker.com/r/fluent/fluent-bit/
Apache License 2.0
67 stars 75 forks source link

Incorrect version in Dockerfile in 1.0 branch #20

Open varun-da opened 5 years ago

varun-da commented 5 years ago

In the line https://github.com/fluent/fluent-bit-docker-image/blob/1.0/1.0/Dockerfile#L12, it picks up master.zip, as long as master matches ENV FLB_VERSION 1.0.1 things are fine, when master changes, this will not be fine. Best to use v$FLB_VERSION.zip similar to https://github.com/fluent/fluent-bit-docker-image/blob/0.14/0.14/Dockerfile#L11.

The docker layout is also a bit confusing because these previous versions also exists in v1.0:

And a Dockerfile exists in the main fluent-bit repo:

Docker hub images are produced from this repo: https://hub.docker.com/r/fluent/fluent-bit, so I guess the Dockerfile from the main repo can be ignored and is used for dev purposes?