search

fluent / fluent-bit-go

Fluent Bit Golang package to build plugins
Apache License 2.0
189 stars 52 forks source link

Update to Go1.14 & misc changes #31

Closed elsesiy closed 4 years ago

elsesiy commented 4 years ago

Fix panic due to timestamp type assertion Add go modules to examples & update dockerfile Bump version of ugorji/go to 1.1.7 Go format

elsesiy commented 4 years ago

@edsiper @wfernandes Please have a look and let me know if anything is missing from this PR, thanks

wfernandes commented 4 years ago

@elsesiy Thanks for this PR! Most of the changes look good to me. Is it possible to split the work into separate commits? And could you also follow the commit message convention, I think that would make it easier for @edsiper to track the changes as well. For example, examples: Fix panic due to timestamp type assertion modules: Bump version of ugorji/go to 1.1.7 output: go fmt

edsiper commented 4 years ago

@elsesiy ping

elsesiy commented 4 years ago

So how do you want me to separate the changes exactly? I’m not familiar with the commit message convention and they seem to differ for the various repos under this org.

edsiper commented 4 years ago

as was suggested above:

https://github.com/fluent/fluent-bit-go/pull/31#issuecomment-626794533

elsesiy commented 4 years ago

@edsiper My question was related to how fine-grained the commits should be e.g. should be adding a gitignore file a separate commit. Anyway, I split the work in 4 commits now, please have another look and let me know.

elsesiy commented 4 years ago

@edsiper @wfernandes Is this still missing anything?

wfernandes commented 4 years ago

LGTM. I no longer have a merge access but I'm sure @edsiper will get to it. 🙂

elsesiy commented 4 years ago

@edsiper Ping

elsesiy commented 4 years ago

@edsiper @PettitWesley Can anybody take a look please?